Update fcs 26

[baronfel]

Update to latest FCS 26 packages, and react to API updates:

• SynPat.Tuple and SynExpr.Tuple's first parameter is now a boolean signifying struct-ness
• SynExpr.Match doesn't have the 4th parameter, isExnMatch anymore
• FSharpField.DeclaringEntity is optional now to support anonymous records. This means that Record Stub generation shouldn't work for anon records.

[Krzysztof-Cieslak]

Looks good to me, but let's wait for CI tests to pass.

[baronfel]

I have some test differences locally around the linter, but I'm not sure how much of that is my machine vs the test environments. I'd really love at some point to run the tests in docker containers keyed to a particular scenario to help limit the variability some.

[baronfel]

Alright, the test failures I see locally match the failures from the Appveyor build, which are around linting. Have the defaults for the linter changed?

[Krzysztof-Cieslak]

Oh, it seems it's again the problem with Liner using different FCS version (and silently failing/reporting nothing). We probably need Linter release with new FCS

[baronfel]

I can work on that 👍

[enricosada]

Let's stabilize the CI to green, reenabling #332 and fixing #336 (linter fails with FSAC .NET) before merge this, if possibile

I am working on the first now, and the second is already fixed (just need to merge #337 first)

[Krzysztof-Cieslak]

For #336 - it seems the FSharpLint with fixed .Net target is out (0.10.4) but we will need a new version with bumped FCS anyway, so we can update FSharpLint as part of this PR.

[enricosada]

@Krzysztof-Cieslak do it, but wait for merge it.

because fsharplint require Dotnet.Proj.Info >= 0.30.
Current in FSAC is not compatible.

The PR #337 update FSAC to 0.30 too, but i'd like ci green back first.

[Krzysztof-Cieslak]

Well, FSharpLint with FCS 26.0 is not ready yet, so we are waiting anyway ;-)

[baronfel]

It's good to get this all done one way or the other :) FCS 27 will hopefully drop very soon after the matching Visualfsharp merges and it'll be good to have a handle on which components need to be updated in what order.

[baronfel]

The FSharpLint PR is at fsprojects/FSharpLint#314

[baronfel]

alright, we're unblocked from the FSharpLint perspective. I can't do the update on this branch yet because of the version constraints that @enricosada mentioned, but once that's updated it should be an easy change.

[baronfel]

rebased on top of #337 so that we're ready to go when that one is merged :) This let me update to latest FSharpLint, which had a small API change.

[baronfel]

Looks like only test failures are related to linting, I'll take a look today.

[enricosada]

@baronfel i'll release v0.35 before FCS 26.
After that this PR + v0.36

I written a short TODO in https://github.com/fsharp/FsAutoComplete/projects

i have one more PR to get in for v0.35

[baronfel]

@enricosada that's fine with me. I'm just hoping to have this update done before the release of VS 2019 (and the associated VF# release checkpoint) so that we have a clear pathway to do that merge+update easily.

[Krzysztof-Cieslak]

I think everything else that we wanted to do before this is done. @baronfel can you rebase on master again?

[baronfel]

yep! rebasing now

[baronfel]

green!

[enricosada]

Awesome, let me release v0.35 tonight, and i'll merge this after

[baronfel]

Way to go team :)

[enricosada]

Merged. Thank @baronfel !

[baronfel]

🎆