Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component design guidelines: incorrect info on NoEquality/NoComparison #634

Closed
yawaramin opened this issue Mar 11, 2017 · 1 comment
Closed

Comments

@yawaramin
Copy link

In the Component Design Guidelines, section 5.1, we have the following passage:

F# record types compile to a simple .NET class. These are suitable for some simple, stable types in APIs. You should consider using the [<NoEquality>] and [<NoComparison>] attributes to suppress the automatic generation of interfaces.

... with a corresponding code example showing how an F# type with these attribute markers is represented in C# without equality and comparison methods.

However, this information is incorrect: see http://stackoverflow.com/q/42656143/20371

My question is, how should we update this section to make it clear that other CLR languages will not honour the F# NoEquality/NoComparison attributes?

@dsyme
Copy link
Contributor

dsyme commented Jun 18, 2020

The component spec is now here: https://docs.microsoft.com/en-us/dotnet/fsharp/style-guide/component-design-guidelines

Please update the component spec by editing it directly there and sending a pull request

@dsyme dsyme closed this as completed Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants