Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get and set files property through reflection #68

Closed
JarekW opened this issue Jan 24, 2017 · 0 comments
Closed

Get and set files property through reflection #68

JarekW opened this issue Jan 24, 2017 · 0 comments
Assignees
@szymach
Labels
Uploadable
Projects
Object manipulation
Milestone
2.0

Comments

@JarekW
Copy link
Contributor

JarekW commented Jan 24, 2017 •
edited
Loading

If class has file field but doesn't has setter for it, for example file is set in constructor, then NoSuchPropertyException is thrown down here

It should be done as doctrine do this - through reflection.

revert #8

Moreover getters should also change. Current implementation with PropertyAccessor block developers from using php7 return types declaration.
@JarekW JarekW changed the title [Uploadable] Set files property through reflection [Uploadable] Get and set files property through reflection Jan 24, 2017
@szymach szymach changed the title [Uploadable] Get and set files property through reflection Get and set files property through reflection May 29, 2017
@szymach szymach added this to TODO in Object manipulation Jun 8, 2017
@szymach szymach added this to the 2.0 milestone Jun 21, 2017
@szymach szymach self-assigned this Jul 26, 2017
@szymach szymach mentioned this issue Aug 23, 2017
Merged
@chives chives closed this as completed in #98 Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymach szymach

Labels
Uploadable
Projects
No open projects
Object manipulation
TODO
Milestone
2.0
Development

No branches or pull requests
2 participants
@szymach @JarekW