Changed reflections to property accessors in uploadable. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -70,14 +80,19 @@ public function getFile() | |||
| return $this->file; | |||
| } | |||
|
|
|||
| public function getFileKey() | |||
| public function deleteFile() | |||
There was a problem hiding this comment.
Well it's not intened to be used by property accessor, but to allow to explicite file deletion (if that's what bothers you).
There was a problem hiding this comment.
It doesn't bother be in context of property accessor but rather in sense of some naming convention used by Symfony2 - http://symfony.com/doc/current/contributing/code/conventions.html. We should give not only good but superior examples in documentation because they will be often used (read: copy-pasted) by end users :)
chives
added a commit
that referenced
this pull request
Jul 16, 2013
Changed reflections to property accessors in uploadable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problems with proxies.