Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weird zip vs zipinner semantics #336

Open
adamklein opened this issue Jan 25, 2016 · 0 comments
Open

weird zip vs zipinner semantics #336

adamklein opened this issue Jan 25, 2016 · 0 comments

Comments

@adamklein
Copy link
Contributor

I noticed that Zip returns a series of opt 'T * opt 'T, whereas ZipInner returns series of 'T * 'T. Besides API confusion, I think the result is unintuitive:

var f = Deedle.Frame.FromRecords(
    new [] {
        new { b = 1.0, c = 5.0 },
        new { b = 2.0, c = Double.NaN },
        new { b = 3.0, c = 7.0 }
    });

f.GetColumn<double>("b")
    .ZipInner(f.GetColumn<double>("c"))
    .SelectValues(t => Double.IsNaN(t.Item2))
    .Format().Dump();

==>

0 -> False     
1 -> <missing> 
2 -> False     
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant