Npm package ci #60
Merged
Npm package ci #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omaus
reviewed
Aug 3, 2023
| @@ -0,0 +1 @@ | |||
| Never open these test files and save them with libre office or microsoft excel. They will automatically standardize the files to their favored format, making them all uniform and working with both OpenXml and Exceljs. | |||
There was a problem hiding this comment.
You might clarify this a bit since it is unclear:
"Never open these files and save them" – so I shall not open them but I can save them?
"They will automatically standardize the files to their favored format, making them all uniform and working with both OpenXml and Exceljs." – but this is good, isn't it? If it is not: why?
There was a problem hiding this comment.
You can open, but never save. This would uniform the format. This is not good, as we want to test readability of different flavors of .xlsx. OpenXml writes different xlsx to excel. These differences are tested with some of these files.
There was a problem hiding this comment.
Then you might state this in the Readme as well. 😉
omaus
reviewed
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altough npm package release is not finished, i need the current fsspreadsheet version fully released on nuget for ARCtrl tests.
So please review -> merge -> publish to nuget asap