Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If R is not installed, just doing #r "RProvider.dll" will raise and error #1

Closed
wants to merge 6 commits into from

Conversation

ovatsus
Copy link
Contributor

@ovatsus ovatsus commented Oct 23, 2013

So we need two scripts, FsLab.fsx and FsLabWithR.fsx (or similar names)
Created GenerateScripts.fsx to automate this and integrated it into build.cmd. Also added more path combinations

@tpetricek
Copy link
Member

I think the user experience would be better if you had just a single fsx file. Perhaps it would be reasonable to change the R provider so that it does not throw an exception (it can generate a type with a member <Note> saying that R installation was not found or something like that...)

@ovatsus
Copy link
Contributor Author

ovatsus commented Oct 23, 2013

Yes, that would be much better
Do you want me to make another pull request without that bit?

@tpetricek
Copy link
Member

Let's first wait for the agreement on the issue regarding R provider and then we'll either go with this, or you can update. Thanks!!

@tpetricek
Copy link
Member

The RProvider now handles missing R installation better - so we can probably close this - unless you added some other features in the pull request?

@ovatsus
Copy link
Contributor Author

ovatsus commented Nov 18, 2013

There were some other fixes here regarding the include paths and the Math.Net assemblies, but I'll resubmit

@ovatsus ovatsus closed this Nov 18, 2013
tpetricek pushed a commit that referenced this pull request Feb 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants