Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security fix: Anonymous users must not leak submitter names #168

Merged
1 commit merged into from
Aug 19, 2020

Conversation

pcworld
Copy link
Contributor

@pcworld pcworld commented Aug 18, 2020

The arbitrary jsonquery feature now needs to be explicitly enabled for
routes and is only ever allowed for authenticated users (because they
currently have access to all data anyway).

For the /api/documents route, we manually parse and validate the query
and build it from scratch for unauthenticated users, without
reverting to jsonquery.

Before, it was possible to efficiently extract submitted_by names by
applying restrictions in the form of `submitted_by LIKE '<prefix>%' to
the /api/documents route. A proof of concept exploit has been developed
using a bisection algorithm (interval halving) that extracts submitter
names of arbitrary protocols (even those that have not been validated
yet) in a matter of seconds.

The arbitrary jsonquery feature now needs to be explicitly enabled for
routes and is only ever allowed for authenticated users (because they
currently have access to all data anyway).

For the /api/documents route, we manually parse and validate the query
and build it from scratch for unauthenticated users, *without*
reverting to jsonquery.

Before, it was possible to efficiently extract submitted_by names by
applying restrictions in the form of `submitted_by LIKE '<prefix>%' to
the /api/documents route. A proof of concept exploit has been developed
using a bisection algorithm (interval halving) that extracts submitter
names of arbitrary protocols (even those that have not been validated
yet) in a matter of seconds.
ghost pushed a commit to fsmi/odie-client that referenced this pull request Aug 19, 2020
@ghost ghost merged commit 083695d into fsmi:master Aug 19, 2020
@TehMillhouse
Copy link
Contributor

Good work catching and fixing these security issues, I appreciate the care that went into this. 👌

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants