Security fix: Anonymous users must not leak submitter names #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcworld
force-pushed
the
submitter-leak
branch
2 times, most recently
from
8a8e0bc
to
e3e7323
Compare
pcworld
added a commit
to pcworld/odie-client
that referenced
this pull request
Aug 18, 2020
Accompanying change to fsmi/odie-server#168
The arbitrary jsonquery feature now needs to be explicitly enabled for routes and is only ever allowed for authenticated users (because they currently have access to all data anyway). For the /api/documents route, we manually parse and validate the query and build it from scratch for unauthenticated users, *without* reverting to jsonquery. Before, it was possible to efficiently extract submitted_by names by applying restrictions in the form of `submitted_by LIKE '<prefix>%' to the /api/documents route. A proof of concept exploit has been developed using a bisection algorithm (interval halving) that extracts submitter names of arbitrary protocols (even those that have not been validated yet) in a matter of seconds.
pcworld
force-pushed
the
submitter-leak
branch
from
e3e7323
to
58ef7cf
Compare
ghost
pushed a commit
to fsmi/odie-client
that referenced
this pull request
Aug 19, 2020
Accompanying change to fsmi/odie-server#168
ghost
merged commit 
|
Good work catching and fixing these security issues, I appreciate the care that went into this. 👌 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arbitrary jsonquery feature now needs to be explicitly enabled for
routes and is only ever allowed for authenticated users (because they
currently have access to all data anyway).
For the /api/documents route, we manually parse and validate the query
and build it from scratch for unauthenticated users, without
reverting to jsonquery.
Before, it was possible to efficiently extract submitted_by names by
applying restrictions in the form of `submitted_by LIKE '<prefix>%' to
the /api/documents route. A proof of concept exploit has been developed
using a bisection algorithm (interval halving) that extracts submitter
names of arbitrary protocols (even those that have not been validated
yet) in a matter of seconds.