Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from gopkg.in and rename organization #108

Closed
nathany opened this issue Dec 17, 2015 · 8 comments
Closed

Move away from gopkg.in and rename organization #108

nathany opened this issue Dec 17, 2015 · 8 comments

Comments

@nathany
Copy link
Contributor

nathany commented Dec 17, 2015

When forking howeyc/fsnotify to modify the API, I decided to use gopkg.in to version the fsnotify library, given that further breaking changes were planned (and still are).

With the success of GO15VENDOREXPERIMENT and vendoring, there is less reason to use gopkg.in. It doesn't really cause any trouble to keep gopkg.in right now, but...

One disadvantage of having a version # in the import path is that internal packages must be specified differently on each branch (v1, v0, master). Right now fsnotify is only a single package, but it would be nice to split out low-level drivers for each OS (see #75). It's certainly doable, but seems like unnecessary complication.

If we made this change, we could do so in a way that leaves the existing import paths in place, while moving the issue tracker and active development to a new import path:

import "gopkg.in/fsnotify.v0"
import "gopkg.in/fsnotify.v1"

import "github.com/fsnotify/fsnotify"

Additionally, we would continue to tag releases, and tags can be checked out in git whether or not vendoring tools directly support doing so.

For? Against? Proposed new import paths?

@nathany
Copy link
Contributor Author

nathany commented Jan 4, 2016

Part of this move would be to adopt @rjeczalik's notify library as an alternative available from the same organization. Any low-level "drivers" for specific platforms would also exist under the new organization.

@omeid
Copy link

omeid commented Jan 16, 2016

I am for moving away from gopkg. For reproducible builds as you explained vendoring is the way to go.

This is a very low level library and upgrading shouldn't be a big hassle for those who want to stay up to date.

@nathany
Copy link
Contributor Author

nathany commented Jan 21, 2016

I'm planning to rename the organization as well, since the "go-" prefix is a gopkg.in thing.

@nathany nathany changed the title Move away from gopkg.in Move away from gopkg.in and rename organization Feb 7, 2016
This was referenced Feb 12, 2016
@nathany
Copy link
Contributor Author

nathany commented Feb 18, 2016

I'm preparing to rename the organization now.

nathany added a commit that referenced this issue Feb 18, 2016
nathany added a commit that referenced this issue Feb 18, 2016
@nathany
Copy link
Contributor Author

nathany commented Feb 18, 2016

The move to https://github.com/fsnotify/fsnotify is done, though I have to ensure CI is still working and update the website.

GitHub automatically redirects https://github.com/go-fsnotify/fsnotify to https://github.com/fsnotify/fsnotify.

I tested go get gopkg.in/fsnotify.v1 and it still works, which I did not expect. If we run into any problems, or if we ever need to include github.com/fsnotify/fsnotify in an internal import path, I can put a repository up at github.com/go-fsnotify/fsnotify with a "maintenance has moved" message in the README.

nathany added a commit to fsnotify/website that referenced this issue Feb 18, 2016
nathany added a commit to fsnotify/fsevents that referenced this issue Feb 18, 2016
@nathany
Copy link
Contributor Author

nathany commented Feb 18, 2016

All done.

@nathany nathany closed this as completed Feb 18, 2016
dmitshur added a commit to gopherjs/gopherjs that referenced this issue Mar 8, 2016
The import path of this package has changed to github.com/fsnotify/fsnotify.

The old import path still works, but that was an unplanned coincidence.
It is no longer officially supported.

See fsnotify/fsnotify#118 (comment)
and fsnotify/fsnotify#108 (comment)
for source. /cc @nathany

According to https://github.com/fsnotify/fsnotify#api-stability there
are future API changes planned, but we can easily update our usage
when that happens, so I don't think we need to vendor it at this time.
anthonyfok added a commit to anthonyfok/viper that referenced this issue Apr 20, 2016
Rename "gopkg.in/fsnotify.v1" to "github.com/fsnotify/fsnotify"
per upstream recommendation.

See fsnotify/fsnotify#108 for rationale.
anthonyfok added a commit to gohugoio/hugo that referenced this issue Apr 20, 2016
Rename "gopkg.in/fsnotify.v1" to "github.com/fsnotify/fsnotify"
per upstream recommendation.

See fsnotify/fsnotify#108 for rationale.
tychoish pushed a commit to tychoish/hugo that referenced this issue Aug 13, 2017
Rename "gopkg.in/fsnotify.v1" to "github.com/fsnotify/fsnotify"
per upstream recommendation.

See fsnotify/fsnotify#108 for rationale.
@cameracker
Copy link

cameracker commented Mar 21, 2018

githubnemo pushed a commit to githubnemo/CompileDaemon that referenced this issue Mar 21, 2018
nakazavva added a commit to nakazavva/goemon that referenced this issue Mar 22, 2018
nakazavva added a commit to nakazavva/goemon that referenced this issue Mar 22, 2018
@nathany
Copy link
Contributor Author

nathany commented Mar 22, 2018

https://github.com/go-fsnotify/fsnotify now has a "moved" message in the README.

See go-fsnotify/fsnotify#1

This was implemented rather poorly as compared to prior transitions (#35). Apologies for that, but what's done is done.

omeid added a commit to go-gonzo/watch that referenced this issue Mar 23, 2018
omeid added a commit to omeid/go-livereload that referenced this issue Mar 23, 2018
tklauser added a commit to cilium/cilium that referenced this issue Apr 24, 2020
The fsnotify package suggests to use the github.com/fsnotify/fsnotify
package patch, see fsnotify/fsnotify#108.

While at it also update to the current master of
github.com/fsnotify/fsnotify in order to fix an unsafe pointer
conversion for #10133

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
aanm pushed a commit to cilium/cilium that referenced this issue Apr 27, 2020
The fsnotify package suggests to use the github.com/fsnotify/fsnotify
package patch, see fsnotify/fsnotify#108.

While at it also update to the current master of
github.com/fsnotify/fsnotify in order to fix an unsafe pointer
conversion for #10133

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants