-
-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move away from gopkg.in and rename organization #108
Comments
Part of this move would be to adopt @rjeczalik's notify library as an alternative available from the same organization. Any low-level "drivers" for specific platforms would also exist under the new organization. |
I am for moving away from gopkg. For reproducible builds as you explained vendoring is the way to go. This is a very low level library and upgrading shouldn't be a big hassle for those who want to stay up to date. |
I'm planning to rename the organization as well, since the "go-" prefix is a gopkg.in thing. |
I'm preparing to rename the organization now. |
The move to https://github.com/fsnotify/fsnotify is done, though I have to ensure CI is still working and update the website. GitHub automatically redirects https://github.com/go-fsnotify/fsnotify to https://github.com/fsnotify/fsnotify. I tested |
All done. |
The import path of this package has changed to github.com/fsnotify/fsnotify. The old import path still works, but that was an unplanned coincidence. It is no longer officially supported. See fsnotify/fsnotify#118 (comment) and fsnotify/fsnotify#108 (comment) for source. /cc @nathany According to https://github.com/fsnotify/fsnotify#api-stability there are future API changes planned, but we can easily update our usage when that happens, so I don't think we need to vendor it at this time.
Rename "gopkg.in/fsnotify.v1" to "github.com/fsnotify/fsnotify" per upstream recommendation. See fsnotify/fsnotify#108 for rationale.
Rename "gopkg.in/fsnotify.v1" to "github.com/fsnotify/fsnotify" per upstream recommendation. See fsnotify/fsnotify#108 for rationale.
Rename "gopkg.in/fsnotify.v1" to "github.com/fsnotify/fsnotify" per upstream recommendation. See fsnotify/fsnotify#108 for rationale.
Resolves #30. See also: fsnotify/fsnotify#108.
https://github.com/go-fsnotify/fsnotify now has a "moved" message in the README. This was implemented rather poorly as compared to prior transitions (#35). Apologies for that, but what's done is done. |
The fsnotify package suggests to use the github.com/fsnotify/fsnotify package patch, see fsnotify/fsnotify#108. While at it also update to the current master of github.com/fsnotify/fsnotify in order to fix an unsafe pointer conversion for #10133 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
The fsnotify package suggests to use the github.com/fsnotify/fsnotify package patch, see fsnotify/fsnotify#108. While at it also update to the current master of github.com/fsnotify/fsnotify in order to fix an unsafe pointer conversion for #10133 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
When forking howeyc/fsnotify to modify the API, I decided to use gopkg.in to version the fsnotify library, given that further breaking changes were planned (and still are).
With the success of GO15VENDOREXPERIMENT and vendoring, there is less reason to use gopkg.in. It doesn't really cause any trouble to keep gopkg.in right now, but...
One disadvantage of having a version # in the import path is that internal packages must be specified differently on each branch (v1, v0, master). Right now fsnotify is only a single package, but it would be nice to split out low-level drivers for each OS (see #75). It's certainly doable, but seems like unnecessary complication.
If we made this change, we could do so in a way that leaves the existing import paths in place, while moving the issue tracker and active development to a new import path:
Additionally, we would continue to tag releases, and tags can be checked out in git whether or not vendoring tools directly support doing so.
For? Against? Proposed new import paths?
The text was updated successfully, but these errors were encountered: