Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set poller.fd twice in newFdPoller #406

Merged
merged 2 commits into from Jan 19, 2022

Conversation

tklauser
Copy link
Contributor

@tklauser tklauser commented Dec 10, 2021

In newEmptyPoller when creating the poller using newEmptyPoller(fd), the
fd field is already set. There is no need to set it again.

@nshalman
Copy link
Contributor

nshalman commented Jan 14, 2022

I thought the tests would run when I did that... 😕

@nshalman
Copy link
Contributor

nshalman commented Jan 14, 2022

@tklauser could you rebase your commit and force push to replace my merge commit to see if that will trigger the tests?
EDIT: It's related to #415. I'll push forward on that first.

In newEmptyPoller when creating the poller using newEmptyPoller(fd), the
fd field of the poller instance is already set. There is no need to set
it again.
Copy link
Contributor

@nshalman nshalman left a comment

This makes sense to me. Being extra cautious and requesting @shogo82148 to confirm too.

inotify_poller.go Show resolved Hide resolved
@nathany nathany added the linux label Jan 19, 2022
@nshalman
Copy link
Contributor

nshalman commented Jan 19, 2022

Having stared at this enough times and seeing the tests pass, I'm satisfied.

@nshalman nshalman merged commit 508ee5e into fsnotify:main Jan 19, 2022
1 check passed
@tklauser tklauser deleted the poller-fd-set branch Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants