Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cross-compilation builds on every push #420

Merged
merged 1 commit into from Jan 19, 2022

Conversation

nshalman
Copy link
Contributor

@nshalman nshalman commented Jan 17, 2022

What does this pull request do?

This creates a Github action to run cross-compilation
builds for all supported targets (or at least that's the idea)

This would have caught #389 and should
catch build failures for supported targets.

Where should the reviewer start?

The output of the builds

How should this be manually tested?

N/A

This would have caught fsnotify#389 and should
catch build failures for supported targets.
@nshalman
Copy link
Contributor Author

nshalman commented Jan 17, 2022

@nshalman
Copy link
Contributor Author

nshalman commented Jan 17, 2022

Even on my illumos system I could have caught that (which is why we should run these cross-compilation builds as part of CI):

~/fsnotify $ git checkout v1.5.0 ; GOOS=freebsd GOARCH=amd64 go build
Note: switching to 'v1.5.0'.
<snip>
HEAD is now at 08848a0 v1.5.0 preparation (#380)
# github.com/fsnotify/fsnotify
./kqueue.go:193:43: undefined: unix.O_SYMLINK

@nshalman nshalman requested a review from nathany Jan 17, 2022
@nshalman
Copy link
Contributor Author

nshalman commented Jan 17, 2022

I think this PR is a good example of how I intend to maintain quality in this project across all supported platforms. I hope you agree, @nathany.

Copy link
Contributor

@nathany nathany left a comment

very good idea :shipit:

@nshalman nshalman merged commit c11d74b into fsnotify:main Jan 19, 2022
1 check passed
@nshalman nshalman deleted the cross-compile branch Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants