Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Tests: change 1ms sleeps to 50ms #422

Merged
merged 3 commits into from Jan 20, 2022

Conversation

nshalman
Copy link
Contributor

@nshalman nshalman commented Jan 20, 2022

What does this pull request do?

When testing the FEN code repeatedly and under
system load I can sometimes get these tests to fail
with a missed WRITE event. With these longer sleeps
I have been unable to produce any test failures.

This is unashamedly in support of #12 / #371

Additionally, this PR gives slightly more friendly names to the sleep durations based on their purposes.

Where should the reviewer start?

Is there any good reason not to do this? It seems reasonable to me and
it prevents spurious test failures.

How should this be manually tested?

N/A

When testing the FEN code repeatedly and under
system load I can sometimes get these tests to fail
with a missed WRITE event. With these longer sleeps
I have been unable to produce any test failures.
@nshalman nshalman requested review from nathany and shogo82148 Jan 20, 2022
nathany
nathany previously approved these changes Jan 20, 2022
integration_test.go Outdated Show resolved Hide resolved
@nshalman nshalman merged commit f482481 into fsnotify:main Jan 20, 2022
23 checks passed
@nshalman nshalman deleted the integration-tests-50ms branch Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants