Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archived on CRAN? #115

Open
bbolker opened this issue Apr 18, 2024 · 7 comments
Open

archived on CRAN? #115

bbolker opened this issue Apr 18, 2024 · 7 comments

Comments

@bbolker
Copy link
Contributor

bbolker commented Apr 18, 2024

The CRAN page says:

Package ‘dotwhisker’ was removed from the CRAN repository.

...

Archived on 2024-04-12 as requires archived package 'prediction'.

However, I can't for the life of me see where this dependence could come from. Neither the DESCRIPTION file of the last-archived version on CRAN, nor the version on github, seem to show any signs of importing prediction ... ?? I suppose there's a possibility of a recursive dependence, but in that case why wouldn't the direct dependence be reported?

Thanks to r-package-devel, I now know that this is through the dependence on the margins package. Short of (1) removing this functionality, (2) switching to the more active marginaleffects package, I don't see a fix other than waiting for the maintainer of the prediction package to resubmit to CRAN ...

Depends: R (>= 3.2.0), ggplot2 (>= 2.2.1),
Imports: grid, gtable, gridExtra, stats, parameters, performance,
        patchwork, margins, dplyr, stringr, ggstance, rlang, purrr
Suggests: ordinal, tibble, knitr, rmarkdown, broom
@LucieCBurgess
Copy link

LucieCBurgess commented Apr 20, 2024

Would be great to get this fixed. The older packages on CRAN have the same dependency.
Very many thanks to the package authors if you are able to give this some attention.

@bbolker
Copy link
Contributor Author

bbolker commented Apr 20, 2024

This is really an "upstream" problem with the prediction package, i.e. you should comment here or here. I did reach the maintainer of prediction by e-mail, they said they were working on it.

In the meantime you should be able to use either remotes::install_github to install first from leeper/prediction, then leeper/margins, then fsolt/dotwhisker, or use remotes::install_version() to install the last-archived versions of the corresponding packages from CRAN ...

e.g.

for (p in c("leeper/prediction", "leeper/margins", "fsolt/dotwhisker")) {
    remotes::install_github(p)
}

I don't think any of these packages have compiled code, so you shouldn't even need to have developer tools installed ...

@LucieCBurgess
Copy link

LucieCBurgess commented Apr 21, 2024

Thank you, that's very helpful - I had already tried remotes::install_version() but it failed due to the missing margins package. Will give these instructions a try.

sammo3182 added a commit that referenced this issue May 2, 2024
@sammo3182
Copy link
Collaborator

Thank you, that's very helpful - I had already tried remotes::install_version() but it failed due to the missing margins package. Will give these instructions a try.

Just submit the new version to CRAN. Have a try to install from there, @LucieCBurgess . Let me know if there's any problem.

Sorry for not addressing this issue sooner...

@sammo3182
Copy link
Collaborator

Apparently, I missed the last email from Thomas Leeper with Ben ... My bad.

And sorry, @LucieCBurgess, it looks like we need to wait for Thomas to update the upstream package margin to restore the package.

If he still cannot release the new margin in a month or so, I will figure out how to switch to margineffect-based function as Ben suggested.

@bbolker
Copy link
Contributor Author

bbolker commented May 2, 2024

In private e-mail Thomas said he had been busy with personal stuff but was hoping to re-submit margins shortly.

@Rainjie-afk
Copy link

@bbolker Thanks for you advise, remotes::install_github('fsolt/dotwhisker') is just fine for me to install dotwhisker(Version 0.8.99)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants