Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ptc module functionality #46

Merged
merged 8 commits into from
Jul 22, 2021
Merged

Improve ptc module functionality #46

merged 8 commits into from
Jul 22, 2021

Conversation

fsoubelet
Copy link
Owner

@fsoubelet fsoubelet commented Jul 22, 2021

Docstrings now detail inner workings and parameters used for functions in cpymadtools.ptc.
Both functions now have a fringe argument and transmit kwargs to either ptc_normal or ptc_twiss depending on which is used.

Adds a cpymadtools.utils module with convenient functionality to export an internal MAD-X table

The docstring now has a detailed description of the function's internal workings.

Added a `fringe` argument which is transmitted to `ptc_setswitch`.
Now takes keyword arguments that will be transmitted to `ptc_twiss`.
@fsoubelet fsoubelet added Documentation Improvements or additions to documentation Enhancement Improvements to an existing feature labels Jul 22, 2021
@fsoubelet fsoubelet self-assigned this Jul 22, 2021
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #46 (d5a4397) into master (e661678) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   95.70%   95.74%   +0.03%     
==========================================
  Files          32       33       +1     
  Lines        1445     1456      +11     
==========================================
+ Hits         1383     1394      +11     
  Misses         62       62              
Impacted Files Coverage Δ
pyhdtoolkit/cpymadtools/track.py 100.00% <ø> (ø)
pyhdtoolkit/cpymadtools/twiss.py 100.00% <ø> (ø)
pyhdtoolkit/cpymadtools/__init__.py 100.00% <100.00%> (ø)
pyhdtoolkit/cpymadtools/ptc.py 100.00% <100.00%> (ø)
pyhdtoolkit/cpymadtools/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e661678...d5a4397. Read the comment docs.

@fsoubelet fsoubelet changed the title Improve ptc.get_rdts functionality Improve ptc module functionality Jul 22, 2021
@fsoubelet fsoubelet merged commit 67e953f into master Jul 22, 2021
@fsoubelet fsoubelet deleted the ptc_rdts branch July 22, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Enhancement Improvements to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant