Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern twiss fix #53

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Pattern twiss fix #53

merged 2 commits into from
Sep 7, 2021

Conversation

fsoubelet
Copy link
Owner

Starting with cpymad 1.9.0, Table.selected_rows() now actually returns the indices of the selected elements rather than returning a boolean mask.

The previous behavior had been worked around in get_pattern_twiss.
This PR removes the workaround and adapt to cpymad >= 1.9.0 which is now the minimum required versoin.

@fsoubelet fsoubelet added Bug Something isn't working Enhancement Improvements to an existing feature labels Sep 7, 2021
@fsoubelet fsoubelet self-assigned this Sep 7, 2021
@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #53 (fd54106) into master (7ecaed4) will increase coverage by 1.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   95.46%   96.57%   +1.10%     
==========================================
  Files          37       36       -1     
  Lines        1698     1605      -93     
==========================================
- Hits         1621     1550      -71     
+ Misses         77       55      -22     
Impacted Files Coverage Δ
pyhdtoolkit/__init__.py 100.00% <100.00%> (ø)
pyhdtoolkit/cpymadtools/twiss.py 100.00% <100.00%> (ø)
pyhdtoolkit/utils/htc_monitor.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ecaed4...fd54106. Read the comment docs.

@fsoubelet fsoubelet merged commit 0c95013 into master Sep 7, 2021
@fsoubelet fsoubelet deleted the pattern_twiss_fix branch September 7, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Enhancement Improvements to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant