Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import path rewriting and GO15VENDOREXPERIMENT do not mix #348

Closed
pwaller opened this issue Aug 11, 2015 · 4 comments
Closed

Import path rewriting and GO15VENDOREXPERIMENT do not mix #348

pwaller opened this issue Aug 11, 2015 · 4 comments

Comments

@pwaller
Copy link

pwaller commented Aug 11, 2015

Please see golang/go#12111.

In my case, vendor.org/p is fsouza/go-dockerclient. The basic problem is that I cannot import fsouza/go-dockerclient with GO15VENDOREXPERIMENT set (and I want to set it in all of my projects!). I think the only solution may be to avoid the rewriting or rename the /vendor/ directory in this project.

@pwaller
Copy link
Author

pwaller commented Aug 11, 2015

A recommendation from the linked issue is to use a directory called internal instead of vendor. (Though it is preferred to use the new vendoring way wherever it is possible. We might have to wait for GO15VENDOREXPERIMENT to become standard first though).

@bufdev
Copy link
Contributor

bufdev commented Aug 11, 2015

We already renamed it to external, see #339 and #338

@pwaller
Copy link
Author

pwaller commented Aug 11, 2015

@peter-edge aha! Apologies for the noise, I missed the fact I was looking at an out of date module.

@pwaller pwaller closed this as completed Aug 11, 2015
@bufdev
Copy link
Contributor

bufdev commented Aug 11, 2015

All good man haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants