Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move vendor/ to external/ for go 1.5 compatibility and update vendored dependencies #339

Merged
merged 2 commits into from
Jul 30, 2015
Merged

move vendor/ to external/ for go 1.5 compatibility and update vendored dependencies #339

merged 2 commits into from
Jul 30, 2015

Conversation

bufdev
Copy link
Contributor

@bufdev bufdev commented Jul 30, 2015

This PR does two things:

  1. Moves vendor/ to external/ and updates the relevant files. This is re: Need to move vendor/ directory for Go 1.5 compatibility #338
  2. Does an update to vendored dependencies with make vendor. I would have done this on a separate PR but I wanted to make sure it still worked completely.

@bufdev
Copy link
Contributor Author

bufdev commented Jul 30, 2015

Hold of on merging this until I verify a few things

@bufdev
Copy link
Contributor Author

bufdev commented Jul 30, 2015

OK, all good to go.

@fsouza
Copy link
Owner

fsouza commented Jul 30, 2015

Thank you!

@fsouza fsouza merged commit c27df21 into master Jul 30, 2015
@bufdev bufdev deleted the move-vendor branch July 30, 2015 13:53
This was referenced Aug 5, 2015
Open
Closed
Closed
@bufdev bufdev mentioned this pull request Oct 23, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fsouza fsouza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bufdev @fsouza