Debug #698
Draft
Debug #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsouza
added a commit
that referenced
this pull request
Apr 11, 2024
It's not _really_ a new dependency as prettier already depends on it, but let's bring it in. I suspect that users are running into weird encoding issues in #694 (and maybe #698). Rather than spending too much time on this, I'm just taking a shortcut: users confirm that they cannot reproduce the issue in `prettier`, so let's read stdin the same `prettier` does :)
fsouza
added a commit
that referenced
this pull request
Apr 11, 2024
It's not _really_ a new dependency as prettier already depends on it, but let's bring it in. I suspect that users are running into weird encoding issues in #694 (and maybe #698). Rather than spending too much time on this, I'm just taking a shortcut: users confirm that they cannot reproduce the issue in `prettier`, so let's read stdin the same `prettier` does :)
fsouza
added a commit
that referenced
this pull request
Apr 12, 2024
It's not _really_ a new dependency as prettier already depends on it, but let's bring it in. I suspect that users are running into weird encoding issues in #694 (and maybe #698). Rather than spending too much time on this, I'm just taking a shortcut: users confirm that they cannot reproduce the issue in `prettier`, so let's read stdin the same `prettier` does :)
|
I'll keep this open to actually turn some of those fixtures into smoke tests. Will likely rename the branch/PR before getting it merged though. |
This reverts commit 494f25c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.