Skip to content
This repository has been archived by the owner on Oct 31, 2021. It is now read-only.

WIP: Paket #713

Merged
merged 5 commits into from
Sep 25, 2014
Merged

WIP: Paket #713

merged 5 commits into from
Sep 25, 2014

Conversation

forki
Copy link
Contributor

@forki forki commented Sep 20, 2014

Doesn't work yet

@forki
Copy link
Contributor Author

forki commented Sep 20, 2014

Waiting for fsprojects/FSharp.Formatting#197 to get fixed

@forki
Copy link
Contributor Author

forki commented Sep 23, 2014

@vasily-kirichenko @dungpa
what do you think?

</When>
</Choose>
<ItemGroup>
<Content Include="net40\Foq.Usage.fsx">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does Paket generate two new fsx files in seperate folders? We probably want only one depending on the framework we target.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this content adding stuff is still open in Paket. fsprojects/Paket#157
will fix this manually

@dungpa
Copy link
Contributor

dungpa commented Sep 24, 2014

This is cool. Look much easier to maintain in the long term.

There are two new warnings about strong name FSharp.Core at https://ci.appveyor.com/project/dungpa/visualfsharppowertools/build/1.5.0-a1409231530/messages. Could you take a look?

@forki
Copy link
Contributor Author

forki commented Sep 24, 2014

There are two new warnings about strong name FSharp.Core

Should be fixed

@dungpa
Copy link
Contributor

dungpa commented Sep 24, 2014

All good.

Another question: how NuGet target can find NuGet binaries for creating a package now https://github.com/fsprojects/VisualFSharpPowerTools/blob/master/build.fsx#L157-L173?

@ovatsus
Copy link

ovatsus commented Sep 24, 2014

You need to add NuGet.CommandLine to the paket.dependencies file. See fsprojects/FSharp.Data@86dfbf2

@forki
Copy link
Contributor Author

forki commented Sep 24, 2014

I always forget that one ;-)

Will add it to the auto-transform-tool and update PR.

2014-09-24 13:56 GMT+02:00 Gustavo Guerra notifications@github.com:

You need to add NuGet.CommandLine to the paket.dependencies file. See
fsprojects/FSharp.Data@86dfbf2
fsprojects/FSharp.Data@86dfbf2


Reply to this email directly or view it on GitHub
#713 (comment)
.

@dungpa
Copy link
Contributor

dungpa commented Sep 24, 2014

@ovatsus @forki Thank both.

@forki
Copy link
Contributor Author

forki commented Sep 24, 2014

done

dungpa added a commit that referenced this pull request Sep 25, 2014
@dungpa dungpa merged commit d288ac7 into fsprojects-archive:master Sep 25, 2014
@dungpa
Copy link
Contributor

dungpa commented Sep 25, 2014

Thanks a lot. We would love to have GitHub release target that works beautifully on Paket :).

@forki
Copy link
Contributor Author

forki commented Sep 25, 2014

very cool.

Will send PR soon.

@forki forki deleted the Paket branch September 25, 2014 08:22
@forki
Copy link
Contributor Author

forki commented Sep 25, 2014

see #720

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants