Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass unsupported attribute arguments #891

Merged
merged 2 commits into from Dec 6, 2014

Conversation

Projects
None yet
3 participants
@dungpa
Copy link
Member

commented Dec 5, 2014

Close #831.
Close #832.

@@ -1451,7 +1472,7 @@ let ``handle uninstantiated type parameters`` () =

let ``handle generic definitions`` () =
"""open System
let x: Collections.Generic.List<'T> = failwith "" """
let x: Collections.Generic.List<string> = failwith "" """

This comment has been minimized.

Copy link
@OkayX6

OkayX6 Dec 5, 2014

Contributor

Why did you change this?

This comment has been minimized.

Copy link
@dungpa

dungpa Dec 5, 2014

Author Member

It's changed to avoid value restriction. It eliminates some errors/warnings in the validation phase later.

if not (bypassAttribute attr) then
writer.WriteLine(formatAttribute ctx attr)
let attrText = formatAttribute ctx attr
// Bypass unsupported attribute arguments (this should be fixed in FCS, albeit not easy)

This comment has been minimized.

Copy link
@OkayX6

OkayX6 Dec 5, 2014

Contributor

Do we track this somewhere? Github issue, or with a failing & ignored test?

This comment has been minimized.

Copy link
@dungpa

dungpa Dec 5, 2014

Author Member

Sorry, no.

Use current module/namespace as an implicit open declaration
Fix #832.
No longer display 'AttributeUsage'.

vasily-kirichenko added a commit that referenced this pull request Dec 6, 2014

Merge pull request #891 from dungpa/unsupported-attributes
Bypass unsupported attribute arguments

@vasily-kirichenko vasily-kirichenko merged commit b404159 into fsprojects:master Dec 6, 2014

1 check passed

continuous-integration/appveyor AppVeyor build succeeded
Details

@dungpa dungpa deleted the dungpa:unsupported-attributes branch Dec 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.