Skip to content
This repository has been archived by the owner on Oct 31, 2021. It is now read-only.

Bypass unsupported attribute arguments #891

Merged

Conversation

dungpa
Copy link
Contributor

@dungpa dungpa commented Dec 5, 2014

Close #831.
Close #832.

@@ -1451,7 +1472,7 @@ let ``handle uninstantiated type parameters`` () =

let ``handle generic definitions`` () =
"""open System
let x: Collections.Generic.List<'T> = failwith "" """
let x: Collections.Generic.List<string> = failwith "" """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's changed to avoid value restriction. It eliminates some errors/warnings in the validation phase later.

vasily-kirichenko added a commit that referenced this pull request Dec 6, 2014
Bypass unsupported attribute arguments
@vasily-kirichenko vasily-kirichenko merged commit b404159 into fsprojects-archive:master Dec 6, 2014
@dungpa dungpa deleted the unsupported-attributes branch December 6, 2014 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Go to metadata] error is displayed [Go to metadata] unsupported attribute argument
3 participants