Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf optimization on diffContentMultiple #317

Closed
wants to merge 4 commits into from
Closed

Perf optimization on diffContentMultiple #317

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c2e03b
Perf optimization on diffContentMultiple
mathias-brandewinder Jun 21, 2023
1b12d0e
Formatting diffContentMultiple
mathias-brandewinder Jun 22, 2023
f92bd38
diffContentMultiple: replace array by mutable list
mathias-brandewinder Jun 23, 2023
ace3b23
Merge remote-tracking branch 'upstream/master' into perf-improvement-…
mathias-brandewinder Jun 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/Avalonia.FuncUI/VirtualDom/VirtualDom.Differ.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,13 @@ module internal rec Differ =
| None -> None

let private diffContentMultiple (lastList: IView list, nextList: IView list) : ViewDelta list =
nextList |> List.mapi (fun index next ->
if index + 1 <= lastList.Length then
Differ.diff(lastList.[index], nextList.[index])
else
ViewDelta.From next
)
let lastList = lastList |> List.toArray
nextList
|> List.mapi (fun index next ->
if index < lastList.Length
then Differ.diff (lastList.[index], next)
else ViewDelta.From next
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let lastList = lastList |> List.toArray
nextList
|> List.mapi (fun index next ->
if index < lastList.Length
then Differ.diff (lastList.[index], next)
else ViewDelta.From next
)
nextList |> List.mapi (fun index next ->
if index + 1 <= lastList.Length then
Differ.diff(lastList.[index], next)
else
ViewDelta.From next
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be an improvement we can merge immediately.


let private diffContent (last: IAttr, next: IAttr) : ViewContentDelta =
match next with
Expand Down