Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace a use of Seq.iteri over a list with List.iteri #374

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

Numpsy
Copy link
Collaborator

@Numpsy Numpsy commented Nov 21, 2023

I've been having a go with with the F# analyzers tools, and got this suggestion that using List.iteri rather than Seq.iteri when the collection is known to be a list should be more efficient

Avalonia.FuncUI\VirtualDom\VirtualDom.Patcher.fs(92,25): Warning GRA-VIRTUALCALL-001 - Consider replacing the call of Seq.iteri with a function from the List module to avoid the costs of virtual calls.

@JaggerJo
Copy link
Member

LGTM

@JaggerJo JaggerJo merged commit 51dff04 into fsprojects:master Nov 22, 2023
1 check passed
@Numpsy Numpsy deleted the rw/seq_list branch November 22, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants