Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add System.Diagnostics.CodeAnalysis.DynamicallyAccessedMembers in a … #399

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

Numpsy
Copy link
Collaborator

@Numpsy Numpsy commented Mar 8, 2024

…couple more places

refs #367

This is some trial and error based on linker warnings and testing rather than a clear 'this was wrong', but on top of the current FuncUI it does appear to be sufficient to get my app running without problems in a NativeAOT build.

Note: For reasons I'm not quite clear on, the compiler wouldn't accept the attributes unless I fully qualified the names, unless I remove the rec from the namespace declaration and put it on the Types module instead - not sure what's going on there

@JaggerJo
Copy link
Member

JaggerJo commented Mar 9, 2024

@Numpsy nice seeing some progress on this. Let me know when it's ready to merge.

@Numpsy
Copy link
Collaborator Author

Numpsy commented Mar 10, 2024

Adding the extra attributes plus marking Bogus as a root assembly seems to have got the ContactBook component sample basically working as a .NET 8 Native AOT build - the main app window and the core functionality of the diagnostics tools are both working for me on my Windows test VM (I haven't tried AOT builds on any other platforms).

I have seem one crash when going down a few levels in the diagnostic tools, but that's outside the main library and I think it's hitting another issue I've seen elsewhere with using DataTemplateView in a TreeView, so I'll create a separate discussion about that one.

@Numpsy Numpsy marked this pull request as ready for review March 10, 2024 23:33
@JaggerJo JaggerJo merged commit 7a0f14a into fsprojects:master Mar 11, 2024
1 check passed
@Numpsy Numpsy deleted the trimming_again branch March 13, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants