Build library as .NET Standard 2.1, tests as .NET Core 3.1 and NUnit 3 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hey that's great. Good job Would you like to be co-maintainer on this repo? |
|
Yah, I'm happy to help. This PR has literally the first line of F# I've ever written, but I do know .NET and Excel. |
|
@jcoliz Nice work! :) I'll make you co-admin |
|
@jcoliz Any chance you could move CI to Github actions? That's what most of the projects in "fsprojects" use |
|
Right, I'm happy to take a TODO on that. I used Azure Pipelines because it's what I know. I've been meaning to figure out Github actions. |
|
Cool thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I converted the library and NUnit tests to .NET Core, please have a look. I'm building these using Azure Pipelines at https://jcoliz.visualstudio.com/ExcelFinancialFunctions/_build. The only real change I had to make is that the tests would not discover without the change to parseArray.
Haven't touched the Excel tests yet.
(Related to Issue #9)