Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added strong name signing #69

Merged
merged 2 commits into from
Jul 30, 2022
Merged

Added strong name signing #69

merged 2 commits into from
Jul 30, 2022

Conversation

derekdiamond
Copy link
Contributor

No description provided.

@jcoliz
Copy link
Member

jcoliz commented Jul 17, 2022

Hi, @derekdiamond. Thanks for contributing this. Could you please describe the case where you are finding it necessary or useful to have this library strong-named?

Thanks!

@derekdiamond
Copy link
Contributor Author

Hi @jcoliz
A pleasure. I have strong named assemblies that reference ExcelFinancialFunctions, and the compile fails because strong named assemblies are not allowed to reference non strong names assemblies. It is irritating, but I need my assemblies to be strong named in case they are referenced by strong named assemblies!

@jcoliz
Copy link
Member

jcoliz commented Jul 27, 2022

Ok, thanks, @derekdiamond . I will look into this. Another one of my repos is asking for it too, I will try it out there first, to avoid breaking anything here.

Also, I noticed you changed

 <GeneratePackageOnBuild>True</GeneratePackageOnBuild>

It this required for strong naming?

@jcoliz jcoliz merged commit 6a9897a into fsprojects:master Jul 30, 2022
@jcoliz jcoliz mentioned this pull request Jul 30, 2022
@jcoliz
Copy link
Member

jcoliz commented Jul 30, 2022

Hi, @derekdiamond . I've merged this, and release an RC package. It would be great if you could try it out, then report back that this meets your needs. Thanks!

https://www.nuget.org/packages/ExcelFinancialFunctions/3.3.0-rc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants