NUnit 3 support

[fstaffa]

• support for NUnit3, based on NUnit 2 support
• no compatibility layer for NUnit2, users will have to create the arguments from scratch
• tested all supported parameters and they work fine
• missing - automated tests, is there some way how such extension would be tested in Fake ?
• missing - do I need to test somehow that support for TeamCity working directory works as expected? I took the logic from NUnit client and I am not sure what is the expected behavior

[inosik]

Do we really need ToolPath & ToolName? Most (or all?) other helpers just have a ToolPath parameter.

[fstaffa]

Makes sense, will merge these two.

[forki]

Is this ready to merge?

[fstaffa]

It is. I have tested it with all in this wrapper and it works fine.
@inosik proposed changing the argument of Framework from string to discriminated union but it probably won't bring much benefit.

[forki]

ok then please change it now, so that we don't have breaking change later

[fstaffa]

Ok, will add there common runtimes which are supported by NUnit 3 and we can expand them later as needed

[fstaffa]

I have changed runtime to discriminated union. I have predefined .net frameworks (2.0, 3.5, 4.0, 4.5) and added Other for any other value.
I was not able to get it running (or get NUnit3 running at all) with mono runtime so I didn't predefine any mono runtime and it will have to be defined manually using Other.
Otherwise this is ready for merge.

[inosik]

Maybe this might help you: https://github.com/nunit/nunit/blob/master/src/NUnitConsole/nunit3-console/ConsoleOptions.cs#L106
And this as well: https://github.com/nunit/nunit/blob/master/src/NUnitEngine/nunit.engine.tests/RuntimeFrameworkTests.cs#L219-L244

[fstaffa]

Thank you, this looks good. I added them (except frameworks 1.0 and 1.1 which should not be supported by NUnit 3)

[johnkors]

+1 on this feature. :)

[forki]

thanks a lot