Wix directory hierarchy #1116
Merged
Wix directory hierarchy #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 25, 2016 16:15
…rchy Added getComponentRefs to get component refs from a directory component hierarchy Changed the Start property in WiXServiceControl to optional to add the ability not to start a service on install
…elected folder into a sub folder
| @@ -96,13 +100,23 @@ type WiXServiceControl = | |||
| Id : string | |||
| Name: string | |||
| Remove : InstallUninstall | |||
| Start : InstallUninstall | |||
| Start : InstallUninstall option | |||
There was a problem hiding this comment.
Yes. But it came just to my mind to extend the InstallUninstall type, like "Never" or "None", instead of option, to accomplish the same task.
There was a problem hiding this comment.
yes plese try to keep breaking changes to a very low
added 2 commits
February 3, 2016 16:04
… avoid breaking changes. Added a new Option "Never" to type InstallUninstall instead and handled the new option in WiXServiceControl for Start, Stop and Remove
Conflicts: src/app/FakeLib/WiXHelper.fs
|
Removed the breaking change from the last commit. The InstallUninstall type now has the new option "Never" |
|
thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to create a full directory component hierarchy, where directories can contain components and directories.
Now you are able to use attachServiceControlToComponents and attachServiceInstallToComponents to on a directory component hierarchy.
There is on minor breaking change:
The property Start in WiXServiceControl is now an option to provide the ability not to start a service on install. If someone has set the property manually, the property has to be changed from e.g. Both to Some(Both)