OpenCoverHelper: Do not assume AppData and ProgramFiles exists by default #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexcfnghk
force-pushed
the
bugfix/fix-opencoverhelper-in-mono
branch
from
1b81af3
to
4e7ec3f
Compare
This fixes calling OpenCover in Linux/MacOS environments where the OpenCoverDefault value throws a ArgumentNullException because the '@@' operator will call Path.Combine to ProgramFiles and AppData which do not exist in Linux/MacOS environments. This fix falls back to the behaviour where ExePath and TestRunnerExePath must be passed explicitly in Mono environments running Linux/MacOS.
rexcfnghk
force-pushed
the
bugfix/fix-opencoverhelper-in-mono
branch
from
4e7ec3f
to
6d324a9
Compare
rexcfnghk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes calling OpenCover in Linux/MacOS environments where the
OpenCoverDefaultsvalue throws aArgumentNullExceptionbecause the@@operator will call
Path.Combineto ProgramFiles and AppData which do notexist in Linux/MacOS environments.
This fix falls back to the behaviour where
ExePathandTestRunnerExePathmust be passed explicitly in Mono environments running Linux/MacOS.