#1194 update fix for mono encoding in ProcessHelper.fs #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to work in all scenarios
|
thanks so much for taking care of this! |
|
@forki it's not yet working. Can you help me understand how do I test the locally built F# Fake without getting it into the nuget? |
|
I'm actually repeating steps of 3f33e8c#diff-f3936af8db25ef04f3cd0ed22cbc36e5 Probably the right way to do is to undo this stuff that I broke in and update specifically HockeyAppHelper and XamarinHelper and GitHelper if needed. |
|
you can run the build?! |
|
@forki I do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to work in all scenarios.
This PR comes as fix for the incomplete pull request #1275 made by me previously.
Problem was that I made incorrect if statement inside another if and thus the encoding enforcement did not work correctly in all cases such as when called from GitHelper or HockeyAppHelper modules.
Apologies for that.