Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade assembly binding redirect for FluentMigrator #1558

Merged
merged 1 commit into from May 19, 2017
Merged

Upgrade assembly binding redirect for FluentMigrator #1558

merged 1 commit into from May 19, 2017

Conversation

bchavez
Copy link
Contributor

@bchavez bchavez commented May 18, 2017

This PR modifies app.config with correct assembly bindings for FluentMigrator.

I recently unpinned FAKE and upgraded from 4.52 to 4.61.2 and bled the following error:

cmd_195

Appears the latest version of FAKE ships with FluentMigratior v1.6.2.

reflector_196
reflector_197


Currently blocked on our CI server without some hacking of the FAKE.config; I would greatly appreciate it if someone could push a minor update.

Thanks,
Brian

☀️ 🌙 "I've been counting down the days and the nights..."

@matthid
Copy link
Member

matthid commented May 19, 2017

Any idea how to test this? (I'll try to release this later today)

@bchavez
Copy link
Contributor Author

bchavez commented May 19, 2017

Hey @matthid thanks! I'm not totally sure tho...

Perhaps we could have a test that loads up all the FAKE.config assemblies and their respective versions and run a scan through all the assembly names and versions in FAKE.config and do let check = Assembly.LoadFile(path) and compare the FAKE.config assembly with check.GetName().Version.

Maybe that could work?

¯\_(ツ)_/¯

💨 🚶 "Bubbles of gas in my brain... Send me off balance, it's not enough"

@matthid matthid merged commit 5bce79c into fsprojects:master May 19, 2017
@matthid
Copy link
Member

matthid commented May 19, 2017

I would release but ctaggart/SourceLink#215

@matthid
Copy link
Member

matthid commented May 26, 2017

Released in https://www.nuget.org/packages/FAKE/4.61.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants