Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes api docs snippets overlapping navigation #2175

Merged
merged 1 commit into from Oct 28, 2018

Conversation

florianbader
Copy link
Contributor

Description

Workaround for the problem in #2161 (Comment from @matthid)

It's not pretty but it works for now. Seems like pre-tags inside a table inside a table with flexible width is not very easy to control.

@matthid
Copy link
Member

matthid commented Oct 28, 2018

Well there is still a small bug somewhere between small and big width sizes (right when the navigation disappears) where stuff is drawn "outside" the browser without being able to scroll there.

But it's much better thanks! Would this be solved by using prism everywhere? Or should we change the generated dom somehow? (No need to do it but if I ever find the time I might change it)

@matthid matthid merged commit cb007f8 into fsprojects:release/next Oct 28, 2018
@florianbader
Copy link
Contributor Author

Well there is still a small bug somewhere between small and big width sizes (right when the navigation disappears) where stuff is drawn "outside" the browser without being able to scroll there.

But it's much better thanks! Would this be solved by using prism everywhere? Or should we change the generated dom somehow? (No need to do it but if I ever find the time I might change it)

@matthid Changing it to prism would be a step in the right direction, because then we can specify the whole layout in the api docs and avoid using tables (which is now predefined by FSFormatting).

@matthid
Copy link
Member

matthid commented Oct 28, 2018

@florianbader But you mean only the tables for the code-blocks, correct? afaik the other tables are defined in the template

@florianbader
Copy link
Contributor Author

@florianbader But you mean only the tables for the code-blocks, correct? afaik the other tables are defined in the template

@matthid Correct. The bug occurs if you have a pre-tag inside a table, so removing one layer of table inside the template isn't enough, you would need to remove the table in the code-blocks and also the table in the api docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants