Add TargetCommitish to CreateReleaseParams

[nikolamilekic]

Description

Added TargetCommitish parameter to the CreateReleaseParams record. This parameter is passed to Octokit's 'NewRelease', and allows for the creation of releases from arbitrary commits when the release tag does not exist yet.

[matthid]

Thanks! Looks good to me. Any idea if we could somehow test this feature? (Is there some testing instance for the github api, for example?)

[nikolamilekic]

Thanks! Looks good to me. Any idea if we could somehow test this feature? (Is there some testing instance for the github api, for example?)

I don't know. :(

I tested it by copy/pasting the whole createRelease function directly into my build script.
Here's it is: https://github.com/nikolamilekic/SaltShaker/blob/master/build.fsx.

What kind of tests would you like to see? Examples of tests of other API calls would be helpful as I'm unfamiliar with the codebase.

[matthid]

Just asking I don't have anything particular in mind. Just assumed you are more familiar with the github api.

What kind of tests would you like to see?

Ideally something which verifies that this works without the need for me to test manually ;)

Examples of tests of other API calls would be helpful as I'm unfamiliar with the codebase.

Sadly, I don't think we have any.

In any case this looks good to me, so I guess I'll just merge as is...

[nikolamilekic]

Just assumed you are more familiar with the github api.

Unfortunately, I'm not. I just assumed there's a way for me to create a release without a tag. After not finding a parameter in CreateReleaseParams I looked under the hood to find the Octokit's NewRelease and there it was. Tested it; it worked; thought it might be useful to others and so here we are.

In any case this looks good to me, so I guess I'll just merge as is...

Thanks!