Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create NuGet package with version "1.0.0" #61

Merged
merged 1 commit into from Oct 26, 2012
Merged

Cannot create NuGet package with version "1.0.0" #61

merged 1 commit into from Oct 26, 2012

Conversation

SimonHohenadl
Copy link
Contributor

I currently have the problem that I cannot build a NuGet package for Machine.Fakes with version "1.0.0", because Fake normalizes the version to "1", which is not accepted by nuget.exe.

I suppose there are other ways to solve this, but I don't see why FAKE should tamper with the version supplied by the user anyway. If I want the version normalized, I can always call the NormalizeVersion function in my build script.

forki added a commit that referenced this pull request Oct 26, 2012
Cannot create NuGet package with version "1.0.0"
@forki forki merged commit c4f9123 into fsprojects:develop Oct 26, 2012
@forki
Copy link
Member

forki commented Oct 26, 2012

It's breaking but I think you're right.
However the breaking change should be no real problem.
If package version is invalid it can't be uploaded and the build will fail.
In this case we can use NormalizeVersion as you suggested.

@SimonHohenadl
Copy link
Contributor Author

Right, I hadn't thought of the fact that it would be a breaking change.
Any idea when you will be able to release this?

@forki
Copy link
Member

forki commented Oct 28, 2012

Simon it is already released on nuget.

@SimonHohenadl
Copy link
Contributor Author

Wow, you release faster than I can read my email. :-)
Thanks!

@forki
Copy link
Member

forki commented Oct 28, 2012

It's deployed via push to master.
That's called "continous deployment". I heard you gave a session about this at devspace ;-)

@SimonHohenadl
Copy link
Contributor Author

Next time, you better give that session. :-)

@funnelweb
Copy link
Contributor

@forki - what's the end-to-end for your continuous deployment setup? I guess you use FAKE itself, but which CD server do you use etc.? I've not set up a CD system before.

Could we reuse the same setup/server etc. for the F# compiler, fsharpx and fsharpbinding? It would be a huge step forward if we did, e.g. we could build linux packages this way, and nuget packages based of the F# open source (e.g. for F# compiler-as-a-service).

@forki
Copy link
Member

forki commented Oct 29, 2012

Im using http://teamcity.codebetter.com - you can easily get an account.

See http://teamcity.codebetter.com/viewType.html?buildTypeId=bt335&tab=buildTypeStatusDiv for the "Fake self build"

I'd happy to help. Maybe we should discuss this in a issue or the mailing list.

@funnelweb
Copy link
Contributor

OK, lets continue the discussion here: fsharp/fsharp#48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants