Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix WiX API page #817

Merged
merged 2 commits into from May 26, 2015
Merged

Conversation

DigitalFlow
Copy link
Contributor

I just discovered that the WiX API page has some missing type definitions and that samples are often rendered incorrectly.
I'm currently fixing this, I'll report when I'm done.

@DigitalFlow
Copy link
Contributor Author

Ok, I fixed the sample code.
Would you leave the visibility of the functions which contain the default parameters as they are, or would you like them to be internal / private?
I saw that some similar functions are public in NuGet helper, what's your best practice in here?

@forki
Copy link
Member

forki commented May 26, 2015

I make most functions public since you never know. But it's OK for now
On May 26, 2015 13:14, "DigitalFlow" notifications@github.com wrote:

Ok, I fixed the sample code.
Would you leave the visibility of the functions which contain the default
parameters as they are, or would you like them to be internal / private?
I saw that some similar functions are public in NuGet helper, what's your
best practice in here?


Reply to this email directly or view it on GitHub
#817 (comment).

@DigitalFlow
Copy link
Contributor Author

Ok, in this case I'm done, thanks.

forki added a commit that referenced this pull request May 26, 2015
@forki forki merged commit 7da5cc0 into fsprojects:master May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants