Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify build.fsx to use a version number based on the Rx package version #16

Closed
jack-pappas opened this issue Jan 26, 2014 · 9 comments
Closed
Labels

Comments

@jack-pappas
Copy link

It may make sense to modify the build.fsx script to create the AssemblyInfo.fs and NuGet package using a version number based on the Rx package version.

For example, for Rx 2.2.2, we might create the FSharp.Reactive package with version number 2.2.2.0. This would make it easier for users to know they're using a version of FSharp.Reactive that matches a specific version of the Rx packages, which is important if Rx is being used in a polyglot solution (e.g., F#/C#, F#/VB.NET). The Rx packages only use the first three numbers in the version number, so we could use the fourth to allow updates/fixes to the FSharp.Reactive package without breaking the versioning scheme.

@panesofglass
Copy link
Collaborator

Good idea. This would be easier after moving to the FSharp.ProjectScaffold.

@panesofglass
Copy link
Collaborator

I don't think this is now possible with the latest commits, as we have now broken backwards compatibility, thereby requiring a major version increment.

@panesofglass
Copy link
Collaborator

It's possible we just ignore that break and fix this when we move to Rx 2.4.

@panesofglass
Copy link
Collaborator

@cloudRoutine @dsyme @forki what are your thoughts on this? Be rigid with respect to SemVer or follow Rx release versions? We do need to update to Rx 2.4; at least that would be nice. We can therefore set a new package version at 2.4.* or 3.0.*.

@cloudRoutine
Copy link
Member

If there's a long term intention for this library to include modules related to Functional Reactive Programming outside of the scope of the Reactive Extensions (e.g. an implementation of Elm's Signal Graphs) then semantic versioning should be followed, the version of the Rx library referenced can be stated in the package notes and the readme for the repository.

Otherwise the 2.4.* scheme seems preferable.

@forki
Copy link
Member

forki commented Sep 24, 2014

Don't follow their releases. This would be insane since then you would have to release everytime they release.

Just embrace semver. Maybe by using paket

@panesofglass
Copy link
Collaborator

@forki 👍 for packet. I anxiously await your PR! ;)

@rodrigovidal
Copy link
Member

@panesofglass I agree with @forki, I think you should not follow their releases.

@panesofglass
Copy link
Collaborator

Majority perspective is to follow SemVer, so that is what we will do going forward. Please re-open or create a new issue if you would like to discuss further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants