Update to Rx-3.0 #90
Merged
Update to Rx-3.0 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 17, 2016 19:40
Change from nuget packages Rx-Core and family to the new System.Control.Reactive for version 3.0. Since Rx 3.0 no longer supports .NET framework 4.0 and Profile259, these have been removed from the solution. Use of Observable.First in the tests was changed to Observable.Wait due to deprecation of the former.
|
Apologies on the broken build in the middle commit - I missed that there was a nuget target and hadn't updated the |
jakelishman
referenced
this pull request
in WarwickEPR/Endorphin.IO
Aug 19, 2016
|
don't worry about that, it happens all the time to every repo using CI. in fact that's exactly what we want to happen 😉 |
|
did you try having FSharp.Control.Reactive only depend on Reactive.Core? just curious if you know how much of the surface area that would effect. |
|
With only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the project to use the new (v3.0) version of the Reactive Extensions.
Since
System.Reactivehas dropped support for .NET framework 4.0 and Profile259, I have removed them from the solution. I'm not well experienced in building .NET libraries though, so if there's a way around that, I can rectify the PR.