Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bump actions/upload-artifact from 3 to 4" #212

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Revert "Bump actions/upload-artifact from 3 to 4" #212

merged 1 commit into from
Dec 19, 2023

Conversation

abelbraaksma
Copy link
Member

@abelbraaksma abelbraaksma commented Dec 19, 2023 •
edited

@abelbraaksma
Copy link
Member Author

abelbraaksma commented Dec 19, 2023 •
edited

This should fix the fact that test reports are not generated. I.e., we see this on all of the recent PRs, including the #206 that we are reverting here (and also: #207, #208 etc) , which seems to have introduced this issue.

image

@abelbraaksma abelbraaksma added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code compatibility Related to backward or forwards, or F# Core or .NET version compatibility labels Dec 19, 2023
@abelbraaksma abelbraaksma mentioned this pull request Dec 19, 2023
Open
@abelbraaksma
Copy link
Member Author

Yep, this solves it, it works. Reported here: dorny/test-reporter#343.

@abelbraaksma abelbraaksma merged commit 7b20732 into main Dec 19, 2023
6 checks passed
@abelbraaksma abelbraaksma deleted the revert-206-dependabot/github_actions/actions/upload-artifact-4 branch December 19, 2023 16:42
@abelbraaksma abelbraaksma mentioned this pull request Mar 17, 2024
Open
@abelbraaksma abelbraaksma added this to the v0.4.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compatibility Related to backward or forwards, or F# Core or .NET version compatibility dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@abelbraaksma