Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get to 100% coverage, add tests for TaskSeq.zip, mapi, iter, exactlyOne and async variants #31

Merged
merged 10 commits into from
Oct 16, 2022
Merged

Get to 100% coverage, add tests for TaskSeq.zip, mapi, iter, exactlyOne and async variants #31

merged 10 commits into from
Oct 16, 2022

Conversation

abelbraaksma
Copy link
Member

@abelbraaksma abelbraaksma commented Oct 15, 2022 •
edited

GOAL: 100% coverage!!! ✅

That is: 100% coverage for the BL parts of the code: all of TaskSeq.fs and TaskSeqInternal.fs.

This adds missing tests for the following functions

TaskSeq.zip
TaskSeq.exactlyOne
TaskSeq.tryExactlyOne
TaskSeq.map*
TaskSeq.mapi*
TaskSeq.mapAsync
TaskSeq.mapiAsync
TaskSeq.iter*
TaskSeq.iteri*
TaskSeq.iterAsync
TaskSeq.iteriAsync
TaskSeq.empty*
TaskSeq.collect*
TaskSeq.collectSeq*
TaskSeq.collectAsync
TaskSeq.collectSeqAsync
TaskSeq.ofResizeArray

* these had existing tests that I've improved a bit on, most notably, adding mutable-data tests

@abelbraaksma abelbraaksma mentioned this pull request Oct 16, 2022
Closed
@abelbraaksma abelbraaksma changed the title Add missing tests for mapi, map, iter, exactlyOne, tryExactlyOne and async variants Add missing tests for TaskSeq.zip, mapi, map, iter, exactlyOne, tryExactlyOne and async variants Oct 16, 2022
@abelbraaksma
Copy link
Member Author

Turned out that TaskSeq.zip had a nasty little bug. Well, that's why we have tests. Fixed now.

Also, this made me think how zip should behave for lazy sequences. See #32 for a follow-up.

@abelbraaksma abelbraaksma changed the title Add missing tests for TaskSeq.zip, mapi, map, iter, exactlyOne, tryExactlyOne and async variants Get to 100% coverage, add tests for TaskSeq.zip, mapi, iter, exactlyOne and async variants Oct 16, 2022
@abelbraaksma
Copy link
Member Author

💚 LGTM: we reached 100% coverage!!!!

@abelbraaksma abelbraaksma merged commit 6805c30 into main Oct 16, 2022
@abelbraaksma abelbraaksma deleted the add-missing-tests branch October 16, 2022 01:21
@abelbraaksma abelbraaksma added this to the v0.1.0 milestone Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test coverage
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@abelbraaksma