Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Provider for Statistical Data published by Bank for International Settlements #43

Merged
merged 5 commits into from Dec 9, 2016

Conversation

dmicic
Copy link
Contributor

@dmicic dmicic commented Nov 1, 2016

BIS Type Provider added to the F# Data Toolbox as discussed here

Open for comments :)

(Documentation not ready yet)

@tpetricek tpetricek merged commit 19ca9b6 into fsprojects:master Dec 9, 2016
@tpetricek
Copy link
Member

Sorry, this slipped through my inbox when I was on holidays! I've merged it (it looks like a great start) and I'll have a look to see if I have any comments.

@tpetricek
Copy link
Member

I released a version that includes this, so that the next iterations are easier!

  • I made a couple of small changes in Integrate, minor stylistic tweaks #46 - I just removed a couple of unnecessary class .. end bits (F# will infer that the type is a class, so these are usually omitted).
  • I noticed you're using inheritance for the Parser type - I think typical F# code would probably avoid inheritance here (can you parameterize Parser by an int?) I left it the way it is though - it's not essential.
  • Completing the documentation would be great - we need to include sample file in the repo for this (I sadly don't have one, so I was not able to get it to work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants