Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1022: HtmlProvider Self closing table tags #1061

Merged
merged 3 commits into from Jul 21, 2017

Conversation

thinkbeforecoding
Copy link
Contributor

This PR fixes #1022 and also implicitly closed li list items, like the following

<ul>
   <li>1
   <li>2
   <li>3
</ul>

@thinkbeforecoding
Copy link
Contributor Author

The build is failing on the EBay car Html page signature.
It finds an additional Additional site navigation Table that was not found before because it was not well formed...
How should we handle this change ?

@dsyme
Copy link
Contributor

dsyme commented Jul 21, 2017

@thinkbeforecoding Fix the test - it's sounds like you've fixed a bug

@thinkbeforecoding
Copy link
Contributor Author

Ok. I changed the expected result since the new one should be better

@thinkbeforecoding
Copy link
Contributor Author

Previously, when starting new td, or new li without closing the new one, it was nesting them.. and adding a lot of closing tags at the end.
This prevented the HtmlType provider from finding the structure. Now the structure stays as expected and the type provider finds the tables or lists 👍

@thinkbeforecoding
Copy link
Contributor Author

thinkbeforecoding commented Jul 21, 2017

Haha, the build failed because there was an edit on the Dr Who wikipedia page !
A column has been renamed from 'Doctor(s)' to 'Doctor' 😄

@thinkbeforecoding
Copy link
Contributor Author

@dsyme Cool. Everything is compiling and passing tests 👍

@ovatsus ovatsus merged commit 4e3c63c into fsprojects:master Jul 21, 2017
@ovatsus
Copy link

ovatsus commented Jul 21, 2017

👍

@thinkbeforecoding
Copy link
Contributor Author

😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HtmlProvider Self closing table tags
3 participants