Change CSV row representation, improve error handling & support for dynamic lookup #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovatsus
commented
Apr 9, 2013
ovatsus
commented
- Change csv row representation and improve error handling
- The representation was previously just a string[] and on each cell access the conversion was being made (possibly repeatedly)
- Now it's a tuple, and each row is converted as a block (but still each row on deman)
- This improves the display on F# interactive and the debugger, and allows the csv rows to better display on tools that use reflection and support tuples, like generic data grids hooked into fsi
- It also allows the IgnoreErrors flag to ignore rows with different data types on the columns, and not just different numbers of columns
- With this change we achieve feature parity with the csv provider of TryFSharp.org
- Support for dynamic lookup in CSV files
- Promoted CsvFile and CsvRow to top level documented component under FSharp.Data.Csv
- Dynamic lookup with GetColumn(columnName:string) (CSV Type provider should have a GetColumn(columnName:string) method for dynamic lookup #64)
- Optional FSharp.Data.Csv.Extensions API with (?), AsFloat(), AsInteger(), etc... similar to JsonValue
added 7 commits
April 9, 2013 20:30
* The representation was previously just a string[] and on each cell access the conversion was being made (possibly repeatedly) * Now it's a tuple, and each row is converted as a block (but still each row on deman) * This improves the display on F# interactive and the debugger, and allows the csv rows to better display on tools that use reflection and support tuples, like generic data grids hooked into fsi * It also allows the IgnoreErrors flag to ignore rows with different data types on the columns, and not just different numbers of columns * With this change we achieve feature parity with the csv provider of TryFShrap.org
In addition to the already supported "#N/A", add "NA" and ":" to the defaults. "NA" is the default in R datasets, ":" is the default in EU and UK government datasets
It turns out using ToString works exactly the same when displaying a single value, but not when displaying a seq or array of them
tpetricek
added a commit
that referenced
this pull request
Apr 12, 2013
Change CSV row representation, improve error handling & support for dynamic lookup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.