Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for plain control types #1487

Merged
merged 9 commits into from Jul 24, 2023
Merged

Conversation

kant2002
Copy link
Contributor

Closes: #1193

Copy link
Collaborator

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So overall this looks good, however it's a breaking change due to the addition of the union type. I'm personally fine with that, but it will necessitate a major version change.

@cartermp
Copy link
Collaborator

Failed a formatting check: Some files need formatting, run dotnet fake build -t Format to format them

@kant2002
Copy link
Contributor Author

If you have an idea how I can make non-breaking change I’m willing to make change. I only learning F# so maybe I do not see some obvious change.

Also second selfish question. What are usual release cadence for this lib? Or maybe if nightly available from main branch somewhere?

@cartermp
Copy link
Collaborator

Yeah, I don't know of a way to make this non-breaking, so it's fine. I doubt most people rely on this type and pattern match on it.

Release schedule is whenever I cut a release, heh. I'll probably do that soon once this lands, assuming CI gets green.

@kant2002
Copy link
Contributor Author

I think I done with formatting.

Release schedule is whenever I cut a release, heh. I'll probably do that soon once this lands, assuming CI gets green

I like this spirit. Now I can take a look, and shop for fun up for grabs.

@kant2002
Copy link
Contributor Author

Let me wrestle with Fake. 😢

Copy link
Collaborator

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrighty, re-review looks good -- I'll merge this puppy in and see what all else is needed for another update this week.

@@ -20,6 +21,8 @@ jobs:
- name: Restore packages
run: dotnet paket restore
- name: Build and test (Release)
env:
FAKE_DETAILED_ERRORS: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, agreed

@cartermp cartermp merged commit 066a7f3 into fsprojects:main Jul 24, 2023
2 checks passed
@kant2002
Copy link
Contributor Author

Most of issues which I have is that I being unable to make Fake run. So I really should either fix Fake somehow or beg for babysitting me by somebody.

@kant2002 kant2002 deleted the kant/multipart branch July 24, 2023 08:01
@kant2002
Copy link
Contributor Author

@cartermp can I have some fresh and tasty release please ? )

@cartermp
Copy link
Collaborator

cartermp commented Sep 4, 2023

Done!

@cartermp
Copy link
Collaborator

cartermp commented Sep 4, 2023

@kant2002
Copy link
Contributor Author

kant2002 commented Sep 5, 2023

Thank you!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpRequestBody.Multipart should support other form control types
2 participants