Support preview F# langauge features #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -201,6 +201,7 @@ module internal CompilerServiceExtensions = | |||
| [| //yield "--debug:full" | |||
| //yield "--define:DEBUG" | |||
| //yield "--optimize-" | |||
| yield "--langversion:preview" | |||
There was a problem hiding this comment.
Is there any reason why users might need to opt out of that? Can't think of any myself.
There was a problem hiding this comment.
Possibly. You could imagine an fssnip showing off a feature in preview where we decide to change the syntax. That snippet would then break when fssnip updates to a later FCS. But in general I think the ability to show preview features outweighs the small likelihood that we would do something to a preview feature that led to big breaking changes).
Other than that, there's no real mechanical downside. The compiler used to generate data for formatting already has the preview codepaths, they're just not activated unless you flip this flag.
eiriktsarpalis
approved these changes
May 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suppose the downside to these tests is that they may need to be updated over time as new preview features come in.