Raise ArgumentNullException for Array functions #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusty
requested changes
Nov 13, 2022
src/FSharpPlus/Extensions/Array.fs
Outdated
Comment on lines
13
to
14
| |> ArgumentNullException | ||
| |> raise |
src/FSharpPlus/Extensions/Array.fs
Outdated
| @@ -6,6 +6,13 @@ module Array = | |||
|
|
|||
| open System | |||
| open FSharp.Core.CompilerServices | |||
|
|
|||
| let inline private raiseIfNull paramName (paramValue: _ seq) = | |||
There was a problem hiding this comment.
Instead of _ seq I would leave it generic.
Probably you did it like that in order to make it work for separators which is a seq of arrays.
It will null check the sequence, but it won't null check every single element in the sequence, which is kind of ok, since the null check will occur downstream in any case.
There was a problem hiding this comment.
Also, consider moving this function to Internals.fs you can put it in either the Prelude or the Errors module. This way we can use it for other modules like Seq.
There was a problem hiding this comment.
Perfect, will do so.
I wasn't sure if we wanted this to be reused.
gusty
approved these changes
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.