Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ValueTuple #524

Merged
merged 18 commits into from
Nov 28, 2022

Conversation

rodriguestiago0
Copy link
Contributor

No description provided.

@rodriguestiago0 rodriguestiago0 changed the title Added ValueTuple Add support for ValueTuple Nov 24, 2022
src/FSharpPlus/Operators.fs Outdated Show resolved Hide resolved
src/FSharpPlus/FSharpPlus.fsproj Outdated Show resolved Hide resolved
src/FSharpPlus/Operators.fs Outdated Show resolved Hide resolved
@@ -42,6 +42,7 @@ From .Net/F#
- ``Map<'T,'U>``
- ``TimeSpan``
- ``Tuple<*>``
- ``ValueTuple<*>``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tricky. either we support ValueTuple<n> with n < 8 or we do some kind of reflection trick for those tuples greater than 8.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we support for n >= 0 and n <= 8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I remove this line?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, in that case just change it to ValueTuple<*> (* up to 8 elements)

@gusty gusty merged commit f646f98 into fsprojects:master Nov 28, 2022
@gusty gusty mentioned this pull request Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants