Fable #160
Merged
Fable #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@njlr pleas look at the appveyor results |
|
Looks like all tests passed. Happy to review and merge this, thanks @njlr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic Fable compilation and tests.
Unfortunately not everything is ported to Fable due to missing things like
System.Threading. These are hidden behind preprocessor conditionals (#if !FABLE_COMPILER). However, simple things likeQueuedo work.Fable emits warnings when you do type-tests on generics. To make it easier to avoid these, I implemented
IEquatable<'t>for some of the collections.To run the Fable tests:
I'm not sure if the maintainers are willing to accept this PR given how much is broken. Perhaps this can be a starting point we can build from?