some helper functions

[sideeffffect]

No description provided.

[jackfoxy]

What are the types ExtraIDictionary and ExtraIReadOnlyDictionary ?

[sideeffffect]

these are extension classes that add TryFind, which returns an Option (that's the whole point) to C# dictionaries

[teo-tsirpanis]

Just a class to hold the extension methods.

[jackfoxy]

Some of these extension methods, e.g. findExactlyOne, have no covering tests. Please add tests.

[sideeffffect]

these are extension classes that add TryFind, which returns an Option (that's the whole point) to C# dictionaries

[sideeffffect]

I apologize, I've only now realized that there is this typo. It should be Choice2Of2.

[sideeffffect]

Choice2Of2

[sideeffffect]

Choice2Of2

[sergey-tihon]

Can you please open PR with the fix?

…

Sent from my iPhone

On Oct 22, 2021, at 23:52, Ondra Pelech ***@***.***> wrote:  @sideeffffect commented on this pull request. In src/FSharpx.Collections/Collections.fs: > Seq.choose chooser xs /// Extracts from a seq of Choice all the Choice2Of2 elements. All the Choice2Of2 elements are extracted in order. let inline choice2s xs = - let chooser = function - | Choice2Of2 x -> Some x - | _ -> None + let inline chooser a = match a with + | Choice1Of2 x -> Some x I apologize, I've only now realized that there is this typo. It should be Choice2Of2. In src/FSharpx.Collections/Collections.fs: > Array.choose chooser xs /// Extracts from an array of Choice all the Choice2Of2 elements. All the Choice2Of2 elements are extracted in order. let inline choice2s xs = - let chooser = function - | Choice2Of2 x -> Some x - | _ -> None + let inline chooser a = match a with + | Choice1Of2 x -> Some x Choice2Of2 In src/FSharpx.Collections/Collections.fs: > List.choose chooser xs /// Extracts from a list of Choice all the Choice2Of2 elements. All the Choice2Of2 elements are extracted in order. let inline choice2s xs = - let chooser = function - | Choice2Of2 x -> Some x - | _ -> None + let inline chooser a = match a with + | Choice1Of2 x -> Some x Choice2Of2 In src/FSharpx.Collections/Collections.fs: > @@ -481,8 +493,35 @@ module Dictionary = | true,v -> Some v | _ -> None + let inline toSeq (d:seq<KeyValuePair<'a, 'b>>) : seq<'a * 'b> = + d |> Seq.map (fun (KeyValue(x,y)) -> x, y) + + +[<Extension>] +type ExtraIDictionary() = these are extension classes that add TryFind, which returns an Option (that's the whole point) to C# dictionaries — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

[sideeffffect]

The fix: #184