Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android (template) to Android 9.0 #453

Merged
merged 3 commits into from
Jun 18, 2019

Conversation

mallibone
Copy link

Updates the template for Android to target Android 9.0.

Uses the Support libraries v28 as described in this discussion #442.

@mallibone
Copy link
Author

There seems to be an issue with the latest WPF XF platform project. I will check if it is reproducible with a C# XF app.

@SergejDK
Copy link
Collaborator

@mallibone
aren't there changes between XF 4.0.0.425677 and 4.0.0.482894 or are they only internal of XF?

@mallibone
Copy link
Author

aren't there changes between XF 4.0.0.425677 and 4.0.0.482894 or are they only internal of XF?

As far as the release notes go it includes only bugfixes and under the hood improvements.

@mallibone
Copy link
Author

So seems like there was a bug in the previous service release of Xamarin.Forms. Should be good for a final look and test run.

@mallibone mallibone changed the title WIP: Update Android (template) to Android 9.0 Update Android (template) to Android 9.0 Jun 15, 2019
Copy link
Collaborator

@SergejDK SergejDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mallibone

Android Java.Interop Assembly not found.
WPF Allcontrols get StackOverflowException.

@mallibone
Copy link
Author

@SergejDK, I did not touch them intentionally and was not aware that they reference the NuGet packages locally. I'll have a look at them as soon as I get some time - having a bit of a busy week.

@mallibone
Copy link
Author

@SergejDK after a quick peek into the solution. Am I right under the impression that paket is used to allocate the NuGet packages for the samples? It seems that this file defines the NuGet versions for the samples.

@SergejDK
Copy link
Collaborator

@mallibone
yes, I forgot about it.
Surely the paket files should be checked and updated, too.

@mallibone
Copy link
Author

@SergejDK surely it is then... I am not yet that familiar with paket but I will give my best to update the packages for the samples.

@TimLariviere
Copy link
Member

@SergejDK @mallibone The samples crashing is unrelated to this PR.
I updated them in #446
Will take a look at why they're crashing now.

@TimLariviere
Copy link
Member

Android Java.Interop Assembly not found.

@SergejDK Where did you have this error? In the templates or the samples?
Just tried to create a new projet with the updated template and everything is good

@SergejDK
Copy link
Collaborator

@TimLariviere
was a failure on my side...
needed to delete bin/obj, close and open again, rebuild - everything great. (just times where this has to be done....)

@TimLariviere
Copy link
Member

Ok. I'm merging this then. :)
Thanks @mallibone!

@TimLariviere TimLariviere merged commit aaf4bcb into fabulous-dev:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants