Merge branch 'master' into expand-documentation

fsprojects · Jan 24, 2021 · 3686417 · 3686417
2 parents 8c8a9c0 + 6263a31
commit 3686417
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 16 deletions.
diff --git a/docsrc/content/giraffe.fsx b/docsrc/content/giraffe.fsx
@@ -83,3 +83,11 @@ let personHandler =
                 return! json person next ctx
             // and ideally we would deal with case when the parsing fails as well
         }
+
+(**
+The benefit of doing an integration in this way is:
+
+- You get a compilation error when trying to use types that don't have the proper functions defined.
+- You avoid having to use runtime reflection to bind and serialize the Json.
+- You have more control over the serialization than with System.Text.Json or Newtonsoft.Json
+*)
diff --git a/src/Fleece.FSharpData/Fleece.FSharpData.fsproj b/src/Fleece.FSharpData/Fleece.FSharpData.fsproj
@@ -15,9 +15,5 @@
         <PackageReference Update="FSharp.Core" Version="4.6.2" />
         <PackageReference Include="FSharpPlus" Version="1.1.1" />
         <PackageReference Include="FSharp.Data" Version="3.0.0" />
-        <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.0">
-            <PrivateAssets>all</PrivateAssets>
-            <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
-        </PackageReference>
     </ItemGroup>
 </Project>
diff --git a/src/Fleece.NewtonsoftJson/Fleece.NewtonsoftJson.fsproj b/src/Fleece.NewtonsoftJson/Fleece.NewtonsoftJson.fsproj
@@ -15,9 +15,5 @@
         <PackageReference Update="FSharp.Core" Version="4.6.2" />
         <PackageReference Include="FSharpPlus" Version="1.1.1" />
         <PackageReference Include="Newtonsoft.Json" Version="10.0.2" />
-        <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.0">
-            <PrivateAssets>all</PrivateAssets>
-            <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
-        </PackageReference>
     </ItemGroup>
 </Project>
diff --git a/src/Fleece.SystemJson/Fleece.SystemJson.fsproj b/src/Fleece.SystemJson/Fleece.SystemJson.fsproj
@@ -15,9 +15,5 @@
         <PackageReference Update="FSharp.Core" Version="4.6.2" />
         <PackageReference Include="FSharpPlus" Version="1.1.1" />
         <PackageReference Include="System.Json" Version="4.7.1" />
-        <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.0">
-            <PrivateAssets>all</PrivateAssets>
-            <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
-        </PackageReference>
     </ItemGroup>
 </Project>
diff --git a/src/Fleece.SystemTextJson/Fleece.SystemTextJson.fsproj b/src/Fleece.SystemTextJson/Fleece.SystemTextJson.fsproj
@@ -15,9 +15,5 @@
         <PackageReference Update="FSharp.Core" Version="4.6.2" />
         <PackageReference Include="FSharpPlus" Version="1.1.1" />
         <PackageReference Include="System.Text.Json" Version="4.7.1" />
-        <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.0">
-            <PrivateAssets>all</PrivateAssets>
-            <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
-        </PackageReference>
     </ItemGroup>
 </Project>