#183 Manually added stuff from the PR @bartelink

fsprojects · Mar 5, 2024 · e215088 · e215088
1 parent 9bd8b2c
commit e215088
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 9 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -17,7 +17,7 @@
 
     <PackageReleaseNotes>
       14.4.2
-      - Pinned FSharp.Core to 5.0.2 in all library projects
+      - Thanks @bartelink: Pinned FSharp.Core to 5.0.2 in all library projects
 
       14.4.1
       - Fixed missing explicit dependency on FSharp.Core

diff --git a/src/FsHttp/FsHttp.fsproj b/src/FsHttp/FsHttp.fsproj
@@ -36,9 +36,17 @@
     <None Include="..\..\docs\img\logo_small.png" Pack="true" PackagePath="\" />
   </ItemGroup>
   <ItemGroup>
-    <!-- 
-      We require F# Core >= 5 due to string interpolation.
-      AND: We have this in all library projects; NOT in the test projects.
+    <!--
+      - Intentionally depend on a minimal version of FSharp.Core as the package previously did prior to V13
+        see https://github.com/fsprojects/FsHttp/issues/183
+      - Releases 13-14.4.0 did not include a nuspec declaration of their dependency on FSharp.Core V8.0.100,
+        so tools like Paket will gravitate toward those broken versions if we make the version constraint more restrictive
+      - We require F# Core >= 5 due to string interpolation.
+      - We have this in all library projects; NOT in the test projects.
+        (https://fsharp.github.io/fsharp-compiler-docs/fsharp-core-notes.html#Package-authors-should-pin-their-FSharp-Core-reference)
+      - ExcludeAssets is a workaround for malformed FSharp.Core packages https://github.com/dotnet/fsharp/issues/12706 via https://github.com/fsprojects/Paket/issues/4149
+        Removal triggers issues in dotnet publish, e.g. for Lambda projects
+        Also avoids Rider search finding stuff in FSharp.Core.xml
     -->
     <PackageReference Include="FSharp.Core" Version="5.0.2" />
   </ItemGroup>

diff --git a/src/Test.CSharp/Test.CSharp.csproj b/src/Test.CSharp/Test.CSharp.csproj
@@ -3,8 +3,6 @@
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>
     <Nullable>enable</Nullable>
-
-    <IsPackable>false</IsPackable>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/Tests/Tests.fsproj b/src/Tests/Tests.fsproj
@@ -2,9 +2,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <TargetFrameworks>net8.0</TargetFrameworks>
-    <IsPackable>false</IsPackable>
-    <OutputType>Library</OutputType>
-    <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
     <Configurations>Debug;Release</Configurations>
   </PropertyGroup>
   <ItemGroup>